Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pkg/core/xds): remove dependency on pkg/xds/envoy #5244

Merged
merged 2 commits into from
Nov 8, 2022
Merged

refactor(pkg/core/xds): remove dependency on pkg/xds/envoy #5244

merged 2 commits into from
Nov 8, 2022

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Nov 1, 2022 •
edited
Loading

Ran into this while working on a different change

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner November 1, 2022 21:11
@michaelbeaumont
refactor(pkg/core/xds): remove dependency on pkg/xds/envoy
fe6c1f3 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
Merge branch 'master' into refactor/xds_types
df46ccd 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
lahabana
lahabana reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this restriction to golangcilint?

@michaelbeaumont
Copy link
Contributor Author

Can we add this restriction to golangcilint?

I can't figure out how to get depguard to actually work, it doesn't seem to obey the ignore-file-rules in the config. gomodguard doesn't seem to allow import restrictions from certain packages.

@michaelbeaumont michaelbeaumont merged commit c21c686 into master Nov 8, 2022
@michaelbeaumont michaelbeaumont deleted the refactor/xds_types branch November 8, 2022 08:43
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelbeaumont @lahabana @jakubdyszkiewicz